Repository navigation
Conversation
Custom FeatureStore and AsyncFeatureStore implementations must now implement is_monitoring_enabled, is_available, and close. Custom FeatureStoreCore and AsyncFeatureStoreCore implementations must now implement is_available and close. These methods are abstract, so a store that omits one cannot be instantiated. The SDK no longer probes for these methods. CachingStoreWrapper and AsyncCachingStoreWrapper always report status monitoring as enabled and delegate is_available and close to the core. The async in-memory store's is_available is now a coroutine, to match the async interface.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
FDv1 stop now closes the feature store, as FDv2 does, so persistent stores release their connections when the client closes. The sync store wrapper also records that it is closed, so a store failure after close does not start a new availability poller.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3013257. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom
FeatureStoreandAsyncFeatureStoreimplementations must now defineis_monitoring_enabled,is_availableandclose. CustomFeatureStoreCoreandAsyncFeatureStoreCoreimplementations must defineis_availableandclose. The methods are abstract, so a store that omits one cannot be instantiated. A store with no outage state can returnFalsefromis_monitoring_enabled, returnTruefromis_available, and do nothing inclose.The SDK no longer checks whether these methods exist.
CachingStoreWrapperandAsyncCachingStoreWrapperalways report status monitoring as enabled and delegateis_availableandcloseto the core. The async in-memory store'sis_availableis now a coroutine, to match the async interface. The Redis and Consul stores now release their connections inclose.Note
Overview
This PR makes
is_monitoring_enabled,is_available, andcloserequired onFeatureStore/AsyncFeatureStore, andis_available/closerequired on the core interfaces used with caching wrappers. The SDK stops probing for optional methods withgetattr/hasattr; wrappers always delegate to the underlying store/core instead.Caching wrappers now always report monitoring as enabled and forward availability and shutdown directly. Built-in and integration stores gain concrete
closebehavior where needed (Redis pool disconnect, Consul HTTP session close, no-op for in-memory/DynamoDB). Async in-memoryis_availableis now async to match the interface.Client lifecycle closes the feature store when FDv1/Async FDv1 stops. The sync FDv1
_FeatureStoreClientWrapperadds a write lock soclose()waits for in-flight writes, ignores writes after close, and avoids starting availability pollers once closed—reducing races with status listeners that callcloseon failure.Reviewed by Cursor Bugbot for commit 6c452a0. Bugbot is set up for automated code reviews on this repo. Configure here.